Support running as a Docker container #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlasmaPower
force-pushed
the
feature/in-docker
branch
from
88152ef
to
36588b7
Compare
|
Fixed merge conflicts. |
PlasmaPower
force-pushed
the
feature/in-docker
branch
from
b4865d0
to
fdb079c
Compare
Closed
|
Hi @PlasmaPower , Would you be willing to submit the custom port functionality as a separate PR? |
|
Done with #39. |
PlasmaPower
force-pushed
the
feature/in-docker
branch
2 times, most recently
from
8161818
to
989aa66
Compare
|
Also, this removes the need for Docker accepting TCP connections (so you don't have to modify the docker service any more). |
PlasmaPower
force-pushed
the
feature/in-docker
branch
from
989aa66
to
a60cb87
Compare
I'm planning to add support for Kubernetes, and I don't think I'll be using the name based DNS system for that. I think it's better to describe this option as internal networking, which describes the what instead of the how.
|
Hi @PlasmaPower , Would it be possible to re-submit this PR on the develop branch? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example use:
Note: in a Swarm, shinyproxy must be run on a manager node. This can be accomplished with the
deploy.placement.constraintssection ofdocker-compose.yml.application.yml:Edit:
internal-networkingoption was originallyname-networking, see b4865d0.I also added support for a custom port for apps, since I was working on much of the same code. I can move that into a separate PR if you'd prefer.Edit: separated into #39.